Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alert level colors, in addition to hover state color. #1379

Merged
merged 3 commits into from
May 4, 2017

Conversation

cryptoquick
Copy link
Contributor

@cryptoquick cryptoquick commented May 2, 2017

  • CHANGELOG.md updated
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #1345

The problem

The styles for alert level color were removed some time ago. In addition, there were specificity issues that could only be solved with !important, since there were already overrides of the bootstrap theme.

The Solution

With the help of @alexpaxton, add styles back, fix specificity, and also fix hover state.

Copy link
Contributor

@jaredscheib jaredscheib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! LGTM

@cryptoquick cryptoquick merged commit bd1edaa into master May 4, 2017
@cryptoquick cryptoquick deleted the bugfix/1345-alert-level-colors branch May 4, 2017 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants