Improve Resizer Further #1453
Merged
Improve Resizer Further #1453
+74
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default is now 50/50 instead of 60/40, but can be specified on a per use basis
jaredscheib
suggested changes
May 11, 2017
| @@ -159,6 +159,8 @@ class CellEditorOverlay extends Component { | |||
| containerClass="resizer--full-size" | |||
| minTopHeight={MINIMUM_HEIGHTS.visualization} | |||
| minBottomHeight={MINIMUM_HEIGHTS.queryMaker} | |||
| initialTopHeight={INITIAL_HEIGHTS.visualization} | |||
| @@ -10,7 +10,7 @@ import Header from '../containers/Header' | |||
| import ResizeContainer from 'src/shared/components/ResizeContainer' | |||
|
|
|||
| import {VIS_VIEWS} from 'src/shared/constants' | |||
| import {MINIMUM_HEIGHTS} from '../constants' | |||
| import {MINIMUM_HEIGHTS, INITIAL_HEIGHTS} from '../constants' | |||
| static defaultProps = { | ||
| minTopHeight: minimumTopHeight, | ||
| minBottomHeight: minimumBottomHeight, | ||
| initialTopHeight: initialHeight, |
There was a problem hiding this comment.
it's a bit confusing to assign initialHeight to both initialTopHeight and initialBottomHeight -- maybe rename this constant fiftyPercent?
There was a problem hiding this comment.
Chose to use defaultInitialTopHeight and defaultInitialBottomHeight instead of a single constant for both
| } | ||
| } | ||
|
|
||
| const {node, number, string} = PropTypes |
There was a problem hiding this comment.
install and use Prettier for auto-formatting
jaredscheib
approved these changes
May 11, 2017
|
Connect #1427 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
#1427 - First thing people do is resize the page. The initial sizes of
QueryMakervsVisualizationare not idealSolution
ResizeContainerfor initial heightVisualizationandQueryMakeralongside minimum heightsQueryMakerwill initially be 2/3 of the page on loadPreview