Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont sync graphs if there is only one graph #1799

Merged
merged 3 commits into from
Jul 28, 2017
Merged

Dont sync graphs if there is only one graph #1799

merged 3 commits into from
Jul 28, 2017

Conversation

121watts
Copy link
Contributor

@121watts 121watts commented Jul 27, 2017 •
edited
Loading

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #1669

The problem

Console error spam from dygraph's synchronize function.

The Solution

Don't synchronize graphs if there's only one graph ya silly goose.

@jaredscheib jaredscheib self-requested a review July 27, 2017 22:58
jaredscheib
jaredscheib approved these changes Jul 27, 2017
View reviewed changes
Copy link
Contributor

@jaredscheib jaredscheib left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great – good catch. Works as intended now, without errors in console.

I clarified (and fixed a typo in) the changelog to make it more specific.

LGTM

@121watts 121watts merged commit 7f7b30b into master Jul 28, 2017
@121watts 121watts deleted the bugfix/syncronize branch August 18, 2017 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaredscheib jaredscheib jaredscheib approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@121watts @jaredscheib