BUGFIX: 'fields' property missing from queryConfig in DataExplorer #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
changed the title
121watts
changed the title
lukevmorris
approved these changes
Aug 31, 2017
|
|
||
| this.setState({ | ||
| fields: fieldSets[measurement].map(f => { | ||
| return {field: f, funcs: []} |
There was a problem hiding this comment.
You can has implicit return here, yes?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #1576
The problem
It appears the queryConfig in the
DataExplorergot into a state where thefieldskey was missing.The Solution
Toughen up the happy path of query creation in the
FieldListcomponent andtoggleFieldfunction in/queryTransitionsRepro Steps (Assuming you are using Chrome)
DataExporerfieldskey from localStorageNotes
Really we should be validating every qC that gets saved to localStorage and preventing bogus state from getting saved in the first place.