Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Legend Positioning #2040

Merged
merged 4 commits into from
Sep 27, 2017
Merged

Fix Legend Positioning #2040

merged 4 commits into from
Sep 27, 2017

Conversation

alexpaxton
Copy link
Contributor

@alexpaxton alexpaxton commented Sep 27, 2017 •
edited by 121watts
Loading

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #2024

The Problem

  • When hovering over a cell at the bottom of the screen the legend appears on top of the graph, making it hard to actually see what you are doing

The Solution

  • Position the legend above the graph instead of on top of the graph
  • Add indicator arrows to make it more clear which cell the legend is pointing to

Preview

screen shot 2017-09-27 at 10 52 37 am
Normal legend below a graph (has arrow on top)

screen shot 2017-09-27 at 10 52 23 am
Legend above a graph (has arrow on bottom)

Only potential issue here is that the crosshair does not line up with the arrows, which I find slightly distracting

@nhaugo nhaugo requested a review from 121watts September 27, 2017 18:03
121watts
121watts approved these changes Sep 27, 2017
View reviewed changes
Copy link
Contributor

@121watts 121watts left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Pulled it down. Works great. Psyched to get this in there.

@alexpaxton alexpaxton merged commit be58d01 into master Sep 27, 2017
@alexpaxton alexpaxton deleted the fix-legend-positioning branch September 27, 2017 20:41
@nhaugo nhaugo mentioned this pull request Nov 3, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@121watts 121watts 121watts approved these changes

Assignees
No one assigned
Labels
polish ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexpaxton @121watts