Give SuperAdmin DefaultRole on PUT /me #2632
Merged
+57
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, SuperAdmins were given the admin role in an organization when they switched into it (via a PUT to /me). This is undesireable for the comonitoring organization. This PR gives SuperAdmins the default role for the organization when they switch into it.
|
Show that notification for 4 seconds. Change copy from 'signed in' to 'logged in'. Remove concept of userHasRoleInOrg since now obsolete.
jaredscheib
reviewed
Dec 21, 2017
cryptoquick
suggested changes
Dec 21, 2017
There was a problem hiding this comment.
Had to reset my DB due to ISE issue. Will open a new issue for that. Then discovered the code on this branch didn't work in the cases I tried. @desa is coming up with a fix.
jaredscheib
force-pushed
the
feature/superadmin_gets_default_role
branch
from
170c649 to
6bf2d25
Compare
cryptoquick
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, SuperAdmins were given the admin role in an organization
when they switched into it (via a PUT to /me). This is undesireable for
the comonitoring organization. This PR gives SuperAdmins the default
role for the organization when they switch into it.
Additionally, this makes it so that when any user switches organizations, they see a longer-displayed notification that clarifies which organization and what role they have switched into, using the terminology
logged in. And this will happen regardless of whether they were a SuperAdmin or not, and whether (if SuperAdmin) that SuperAdmin had a role in the org before or not.Connect #2641
Connect #2636