Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/annotations update #3104

Merged
merged 5 commits into from
Apr 4, 2018
Merged

Bugfix/annotations update #3104

merged 5 commits into from
Apr 4, 2018
+25 −2

Conversation

ebb-tide
Copy link
Contributor

@ebb-tide ebb-tide commented Mar 31, 2018 •
edited
Loading

  • CHANGELOG.md updated with a link to the PR (not the Issue)
  • Rebased/mergable
  • Tests pass
  • Sign CLA (if not already signed)

Connect #2959

The problem

Annotations do not refresh after initial dashboard mount.

The Solution

Added a setInterval to componentwillreceiveprops of dashboardpage to query for annotations at the auto-refresh interval.

ischolten
ischolten approved these changes Apr 4, 2018
View reviewed changes
Copy link
Contributor

@ischolten ischolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@ebb-tide ebb-tide merged commit b68b6f9 into master Apr 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ischolten ischolten ischolten approved these changes

Assignees

@ischolten ischolten

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ebb-tide @ischolten