Allows users to select tickscript editor with mouse #3252
Conversation
| @@ -316,7 +316,7 @@ export class TickscriptPage extends PureComponent<Props, State> { | |||
| } | |||
| } catch (error) { | |||
| console.error(error) | |||
| notify(notifyTickscriptLoggingError(error)) | |||
| notify(notifyTickscriptLoggingError('Could not collect kapacitor logs')) | |||
There was a problem hiding this comment.
i think we have a central constants file for all error copy
There was a problem hiding this comment.
this was previously just passing through an error and there was nothing in the notifications copy, happy to move.
| if (ref) { | ||
| const {height} = ref.getBoundingClientRect() | ||
| this.setState({height}) | ||
| this.notificationRef = ref |
There was a problem hiding this comment.
what if you put this at the top of this if block, and then use this.notificationRef.getBoundClientRect() etc.? and then you can factor this and lines 30-31 out into a function for setting the height? or if not factoring it out, at least they'll be consistent syntax
| /> | ||
| <label htmlFor="insecureSkipVerifyCheckbox"> | ||
| Unsafe SSL | ||
| {url && |
There was a problem hiding this comment.
maybe some kind of typechecking, prior guard, or default value could be used to ensure url exists? why would we be able to get here without url?
There was a problem hiding this comment.
It was getting a null value right after I saved a new kapacitor configuration.
There was a problem hiding this comment.
I think this component needs to be translated to a class based component, there are enough places that need default values to make it a cleaner experience. However this change was not in service of the issue so didn't want to bog down this PR too much.
There was a problem hiding this comment.
hm. i don't think a url should ever be null after saving a new kapacitor configuration. i suspect introducing this line will cover up part of what, i would agree, should be a larger refactor. could you make a chore issue for the refactor of this component and cite this line and the null upon saving for future consideration?
Removing errors caused by shouldComponentUpdate being called
| @@ -19,7 +19,7 @@ class TickscriptID extends Component { | |||
| onChange={onChangeID} | |||
| placeholder="ID your TICKscript" | |||
| spellCheck={false} | |||
| autoComplete={false} | |||
| autoComplete="false" | |||
There was a problem hiding this comment.
The prop for autocomplete on inputs is "off"
Closes #3236