Fix/import dashboard sources #4068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sers to map sources from imported dashboard to current sources
Co-authored-by: Alex Paxton <[email protected]>
Much less screamy Co-Authored-By: Iris Scholten <[email protected]>
Co-Authored-By: Iris Scholten <[email protected]>
Co-Authored-By: Iris Scholten <[email protected]>
…e with Dynamic Source
ebb-tide
approved these changes
Aug 1, 2018
| @@ -0,0 +1,103 @@ | |||
| import React from 'react' | |||
| import {shallow} from 'enzyme' | |||
| onImportDashboard(dashboard) | ||
| onDismissOverlay() | ||
| const cells = _.get(dashboard, 'cells', []) | ||
| const importedSources = _.get(meta, 'sources', {}) |
There was a problem hiding this comment.
get deep on these two lines plzz?
There was a problem hiding this comment.
word. fyi these don't need to be getDeep since they're not nested. has our convention become that we prefer getDeep generally?
jaredscheib
force-pushed
the
fix/import-dashboard-sources
branch
from
b3e3083 to
e031ef4
Compare
Instantiate source id regex only once & use const name convention.
jaredscheib
force-pushed
the
fix/import-dashboard-sources
branch
from
1c7f7d4 to
80e0e01
Compare
|
I ran EDIT: We figured it out and are going to resolve Circle issues first so that other branches don't check out a failing master. |
Co-Authored-By: Jared Scheib <[email protected]>
…chronograf into fix/import-dashboard-sources
jaredscheib
added a commit
that referenced
this pull request
Aug 2, 2018
Co-authored-by: Iris Scholten <[email protected]> Co-authored-by: Alex Paxton <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3980
What was the problem?
If you have different sources than the dashboard you are importing from, there is no way to map the sources from your import to your current chronograf.
What was the solution?
Add a source mapping page as a part of the import dashboard process.