Add validation to Alert Rule message templates #4479
Merged
+217
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
121watts
approved these changes
Sep 21, 2018
| return exactMatch || fuzzyMatch | ||
| } | ||
|
|
||
| const isValidMessage = (message: string): boolean => { |
There was a problem hiding this comment.
Maybe a test for this function?
| /> | ||
| </div> | ||
| ) | ||
| const RuleMessageText: SFC<Props> = ({rule, updateMessage}) => { |
There was a problem hiding this comment.
I know this started out as an SFC, but I think this would be easier to read and extend if converted to a class with getters for textAreaClass, isValid, and removing the ternaries.
ebb-tide
force-pushed
the
bugfix/validate-alert-rule-messages
branch
from
456901b to
7e2c787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4398
What was the problem?
Kapacitor allows the creation of alert rules/tasks that can not be enabled.
When the alert rule builder sent the BE an alert rule with a message that contained improper templates, it would receive a 422 error (and display can't create alert to user), but the alert rule would still be created in the background.
What was the solution?
Require that the alert message be validated before the Save Rule button is enabled, and notify user that their message contains bad templates. REGEX TO THE MAX!