Fix error when editing kapacitor info in onboarding #5078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ischolten
force-pushed
the
fix/update-kapacitor-name
branch
2 times, most recently
from
bba07af to
c1b16b2
Compare
mavarius
approved these changes
Feb 13, 2019
ischolten
force-pushed
the
fix/update-kapacitor-name
branch
from
c1b16b2 to
38ce543
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5060
Briefly describe your proposed changes:
What was the problem?
setKapacitorDraftwas added as a prop to the KapacitorStep which is used in both the OnboardingWizard and the ConnectionWizard. The ConnectionWizard passes in the prop whereas the OnboardingWizard does not. Any time a user would edit info in the Kapacitor Form from the onboarding flow, they would get an error message.What was the solution?
Make it an optional prop and only use call that function if the function is passed in.