Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui): do not fetch tag values when no measurement tags are available #5716

Merged
merged 2 commits into from
Apr 1, 2021
Merged

fix(ui): do not fetch tag values when no measurement tags are available #5716

merged 2 commits into from
Apr 1, 2021

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Mar 30, 2021 •
edited
Loading

Closes #5715

When no tag keys are available for a measurement, an empty dataset is quickly returned without executing a failing query
SHOW TAG VALUES FROM "autogen"."whatever" WITH KEY IN ()

@sranka sranka changed the title fix(ui): return empty tag values when no tag keys are available fix(ui): do not fetch tag values when no measurement tags are available Mar 30, 2021
@sranka sranka requested a review from ivankudibal March 30, 2021 19:56
@sranka sranka marked this pull request as ready for review March 31, 2021 15:12
@ivankudibal ivankudibal requested a review from tomklapka April 1, 2021 06:56
@sranka sranka merged commit 7815527 into master Apr 1, 2021
@sranka sranka deleted the 5715/invalid_influxql branch April 1, 2021 08:18
@ivankudibal ivankudibal added the cy tb covered by cy label Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivankudibal ivankudibal ivankudibal approved these changes

@tomklapka tomklapka Awaiting requested review from tomklapka

Assignees
No one assigned
Labels
cy tb covered by cy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explorer executes invalid InfluxQL
2 participants
@sranka @ivankudibal