Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): allow to send multiple queries to dashboard #5737

Merged
merged 5 commits into from
Apr 27, 2021

Conversation

sranka
Copy link
Contributor

@sranka sranka commented Apr 22, 2021

Closes #5703

Briefly describe your proposed changes:

  1. Use query from an active tab OOTB
  2. Let the user choose whether to send the active query, or all queries

sendToDashboard

What was the problem?

  • only the query from the first query tab was used, without letting the user know
  • it was not clear what is exactly being sent to a dashboard

What was the solution?

  • active tab query is used, it is a default option
  • the user can choose whether to send only an active query or all queries

@sranka
Copy link
Contributor Author

sranka commented Apr 22, 2021

@timhallinflux I let the user choose what to add (Active Query or All queries) ... does it meet the expectation of the reported issue?

@timhallinflux
Copy link
Contributor

that would work @sranka -- thanks!

@sranka sranka marked this pull request as ready for review April 23, 2021 03:09
@sranka sranka requested a review from ivankudibal April 23, 2021 03:09
@ivankudibal ivankudibal added this to the 1.9.0 milestone Apr 23, 2021
@ivankudibal ivankudibal added the cy tb covered by cy label Apr 26, 2021
@sranka sranka merged commit 9b96d1b into master Apr 27, 2021
@sranka sranka deleted the 5703/send_to_dashboard branch April 27, 2021 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cy tb covered by cy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to save multiple queries to dashboard cell
3 participants