Fix Flash of Unpopulated Graphs on Refresh #967
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @timraymond I think this just needs its conflicts fixed and it looks ready to merge. |
|
@timraymond lets get this merged in. Just fix the conflict and merge. |
timraymond
force-pushed
the
bugfix/tr-flash-unpopulated-graphs
branch
from
843957b to
d1102be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connect #915
If a previous fetch of query results was unsuccessful, a "No Results"
message is displayed by the AutoRefresh component. When it went to fetch
results again, this would briefly be replaced by its composed compoenent
which would be instructed to show its "loading" treatment. Since "No
Results" is usually not a situation that would spontaneously change
without user intervention, this patch stores whether the previous fetch
was successful, and hides the loading treatment during subsequent
fetches if it wasn't.