Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat isolated_build as an alias for wheel_pep517 #6

Merged
merged 1 commit into from
Sep 28, 2020
Merged

treat isolated_build as an alias for wheel_pep517 #6

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions src/tox_wheel/plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,10 +72,7 @@ def tox_package(session, venv):


def wheel_build_package(config, session, venv):
if config.isolated_build:
reporter.warning("Disabling isolated_build, not supported with wheels.")
pep517 = venv.envconfig.wheel_pep517
if pep517:
if config.isolated_build or venv.envconfig.wheel_pep517:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I typoed this and didn't notice:

https://github.com/twisted/ldaptor/pull/180/files#diff-522adf759addbd3b193c74ca85243f7dR31

Copy link
Contributor Author

@graingert graingert Sep 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did I put that warning I wonder ...

@ionelmc I'm not sure, it seems sensible to me to process the flag for its stated purpose rather than claim to disable it while not disabling it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume the warning predates wheel_pep517?

wheel_package = wheel_build_pep517(config, session, venv)
else:
wheel_package = wheel_build_legacy(config, session, venv)
Expand Down