add hostPID command line arg, to fix zombie fsac after the client is force closed #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
used to pass the host process id, when that process exit then fsac will quit too different implementation by os, because mono doesnt support Process.Exited event
enricosada
changed the title
enricosada
changed the title
|
Cool idea! @kjnilsson look OK for calling from vim? |
|
@rneatherway dunno why fails (hang) on windows ci. |
|
strange enough, in my appveyor build image is green (same commits) https://ci.appveyor.com/project/enricosada/fsautocomplete/build/1.0.4 |
the fake `FSIHelper.executeFSI` doesnt timeout
enricosada
force-pushed
the
walking_dead_season_finale
branch
from
7776ac5 to
325d24d
Compare
|
@rneatherway i'll merge this. |
|
Great, I agree. I will have a look at using this feature with Emacs. |
This was referenced Sep 13, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
--hostPIDcommand line arg (optional)used to pass the host process id, when that process exit then fsac will quit too
Pratically, client will pass its PID as
--hostPID=123, and when that process die, also fsac will quit.This should remove issues with zombie process.
in stdio will use the
Quitcommand, andexitfunction on suaveref fsharp/zarchive-vim-fsharp#94 (comment)
ref ionide/ionide-vscode-fsharp#374