Split fsiextraparameters for fsac #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `fsiExtraInteractiveParameters` and `fsiExtraSharedParameters`, which should both be used in favor of the old `fsiExtraParameters`. Some fsi parameters are exclusive to the interpreter and have no compiler equivalent. FSAC will now pass the shared parameters to the compiler and not the interactive parameters. Ionide-vim will append all parameters from both options to the execution of the interpreter (usually `dotnet fsi`). `fsiExtraParameters` will be deprecated and removed from FSAC, so it is best to migrate away from that. See ionide/FsAutoComplete#1210 for more detail.
This gets sent to FSAC and, despite being a no-op, it is different than a `None` in the FSAC options. We do not want to mix old and new fsi extra parameters.
Implements ionide#82
Removing the default for `fsi_extra_parameters` causes an error when concatenating command line args for the interpreter. Wrap in a conditional check for existence. Add a warning message to migrate to the new parameters Implements ionide#82
cannorin
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fsi_extra_parametersNonein the FSAC options.We do not want to mix old and new fsi extra parameters.
fsiExtraInteractiveParametersandfsiExtraSharedParameters, which should both be used in favor of the oldfsiExtraParameters.FSAC will now pass the shared parameters to the compiler and not the interactive parameters.
dotnet fsi).fsiExtraParameterswill be deprecated and removed from FSAC, so it is best to migrate away from that.implements #82