feat: add allow_replace to server resource #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiGuranIonos
requested review from
a team,
rmocanu-ionos,
mimihalescu,
avirtopeanu-ionos,
adeatcu-ionos,
glimberea,
cbeti-ionos and
digna-ionos
and removed request for
a team
adeatcu-ionos
previously approved these changes
Nov 20, 2024
| @@ -198,7 +200,7 @@ | |||
| - Fix documentation for `ionoscloud_server`, `ionoscloud_volume`, `ionoscloud_lan` resources and `ionoscloud_image` data sources | |||
|
|
|||
| ### Enhancements | |||
| - Add configurable fields to `ionoscloud_share` resource. Fields that can be set on creation: `description`, `sec_auth_protection`, `licence_type`. | |||
| - Add configurable fields to `ionoscloud_share` resource. Fields that can be set on creation: `description`, `sec_auth_protection`, `licence_type`. | |||
There was a problem hiding this comment.
@cristiGuranIonos do you use some kind of formatting tool for this file? I'm just curious where these changes are coming from.
There was a problem hiding this comment.
no idea how they got added back. Maybe on merge in some way. Will leave as is, it does not matter.
| - Split tests with build tags | ||
| - Improve http client performance and timeouts | ||
|
|
||
| ### Documentations: | ||
| ### Documentations: |
There was a problem hiding this comment.
@cristiGuranIonos these look like some new white spaces, not sure if you actually wanted to add these. Anyway, it doesn't matter.
There was a problem hiding this comment.
a previous commit had removed these. Not sure how they got added back. Will take a look
Co-authored-by: Deatcu Andrei-Cristian <[email protected]>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this fix or implement?
Checklist
feat:/fix:/doc:/test:/refactor:)