Running GitHub CI on another PR #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of using defines to set the board hardware definitions each board get its own file with the routines to access the hardware functions. This way also third party boards can be implemented without being required to modify the epdiy source. So far only logic from display_ops.c has been ported. Work still also exists to optimize duplicated code. Care has been taken to not break existing code bases. If a board is defined in menuconfig this will still be used.
The goal is to get rid of the config_reg_v*.h files
This should not be done for individual boards.
Boards specific code should be marked as such.
Move signals oe, mode and stv to this Implement start_frame using the ctrl interface
Instead of requiring the user to create a wifi_config.h file, this will use the recommended way to add user-specific configurations from ESP-IDF. At the same time this has the benefit, that the example even compiles when the user did not set the WiFi settings. The settings simply default to empty strings.
Create a separate task, which installs the arduino-esp32 component first. Also set to use the custom partition table in sdkconfig defaults of the weather example. Otherwise the example would not successfully build by default.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just for testing.
See vroland#168