-
Notifications
You must be signed in to change notification settings - Fork 211
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
3 changed files
with
4 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
--- | ||
image: "https://cdn.example.org/absolute.png" | ||
image: https://cdn.example.org/absolute.png?h=188&w=250 | ||
--- | ||
|
||
March the second! |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e24f30c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to be clear, in one code path,
xml_escape
will now be run twice. Is it idempotent, or will it double-escape?e24f30c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It still runs once.
Just modify your Gemfile to test this on your site:
gem "jekyll-feed", git: "https://github.com/jekyll/jekyll-feed"
e24f30c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’m having trouble spotting it.
@bittlingmayer Could you point to line numbers? It would be nice to avoid the double call (for performance reasons only; correctness is not in question)
e24f30c
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pathawks I'm wrong, @DirtyF is correct, somehow I had not seen that it was removed from the other line.