MetaTag: when encoding for XML special characters, handle non-string objects #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…objects
The jekyll-github-metadata plugin, for example, sets `site.title` and
`site.name` to `Jekyll::GitHubMetadata::Value` objects which respond to
`#to_s` and `#to_liquid`, but NOT `#encode`. Therefore, we should cast
to a string if `#encode` is not yet available.
The reason we cast to a string is because the previous code was
"#{k}=#{v}", which was implicitly casting to a string for `v`.
DirtyF
approved these changes
Oct 2, 2020
|
@parkr Do we really need to have that attributes.map { |k, v| "#{k}=#{v.to_s.encode(:xml => :attr)}" }.join(" ") |
|
No worries at all 😄 @jekyllbot: merge +dev |
jekyllbot
added a commit
that referenced
this pull request
Oct 3, 2020
This was referenced Mar 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #325.
The jekyll-github-metadata plugin, for example, sets
site.titleandsite.nametoJekyll::GitHubMetadata::Valueobjects which respond to#to_sand#to_liquid, but NOT#encode. Therefore, we should castto a string if
#encodeis not yet available.The reason we cast to a string is because the previous code was
"#{k}=#{v}", which was implicitly casting to a string forv.