Check post.categories instead of post.category
#357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
parkr
approved these changes
Dec 19, 2021
spec/jekyll-feed_spec.rb
Outdated
| expect(news_feed).to_not match "http://example.org/2015/08/08/stuck-in-the-middle.html" | ||
| expect(category_feed).to match '<title type="html">My awesome site | News</title>' | ||
| expect(category_feed).to match "http://example.org/updates/jekyll/2014/03/04/march-the-fourth.html" | ||
| expect(category_feed).to match "March the fourth!" |
There was a problem hiding this comment.
Could we cover the category: jekyll case too? The fixtures don't seem to have a post with the singular key name
There was a problem hiding this comment.
The fixtures don't seem to have a post with the singular key name
The existing test on master uses a fixture post with a singular key name..
parkr
approved these changes
Dec 19, 2021
|
@jekyllbot: merge +fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
Jekyll::Document#data["categories"]is generated fromdoc.data["category"].Closes #356