Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore missing notification permission from Glide #2422

Merged

Conversation

teobaranga
Copy link
Contributor

Ignores the missing android.permission.POST_NOTIFICATIONS permission caused by some Glide class that's not used in this project. There's a issue already raised but it hasn't been actioned yet: bumptech/glide#4940

This should allow upgrading AGP to 7.4.0 without any issues.

Copy link
Member

@nielsvanvelzen nielsvanvelzen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nielsvanvelzen nielsvanvelzen added bug Something isn't working dependencies Pull requests that update a dependency file labels Jan 16, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Jan 16, 2023
@nielsvanvelzen nielsvanvelzen merged commit d673614 into jellyfin:master Jan 16, 2023
@teobaranga teobaranga deleted the notification_permission_glide branch January 16, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants