Add PlaySessionService to playback rewrite #2428
Conversation
nielsvanvelzen
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| // The queues are lazy loaded so we only load a small amount of items to set as queue on the | ||
| // backend. | ||
| return manager.queue | ||
| ?.peekNext(15) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
| /** | ||
| * The value of this duration expressed as a [Long] number of ticks. | ||
| */ | ||
| private val Duration.inWholeTicks: Long get() = toLong(DurationUnit.NANOSECONDS).div(100L) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
| /** | ||
| * Convert ticks to duration | ||
| */ | ||
| private val Long.ticks get() = div(100L).nanoseconds |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
There we go, the second third big PR for the playback rewrite! This one adds play session support which is pretty essential for Jellyfin.
Changes
Issues
Part of #1057