Rewrite LibraryDreamService with Compose #2498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
enhancement
nielsvanvelzen
removed
the
refactor
nielsvanvelzen
commented
Feb 14, 2023
app/src/main/java/org/jellyfin/androidtv/integration/dream/LibraryDreamService.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/jellyfin/androidtv/integration/dream/LibraryDreamService.kt
Outdated
Show resolved
Hide resolved
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+20
to
+28
| fun AsyncImage( | ||
| modifier: Modifier = Modifier, | ||
| url: String? = null, | ||
| blurHash: String? = null, | ||
| placeholder: Drawable? = null, | ||
| aspectRatio: Double = 1.0, | ||
| blurHashResolution: Int = 32, | ||
| scaleType: ImageView.ScaleType? = null, | ||
| ) { |
Check warning
Code scanning / detekt
The more parameters a function has the more complex it is. Long parameter lists are often used to control complex algorithms and violate the Single Responsibility Principle. Prefer functions with short parameter lists.
nielsvanvelzen
force-pushed
the
compose-librarydreamservice
branch
from
ff22b21 to
5ffa475
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally made these changes about 5 months ago but for some reason never made the PR 🤷. Some future plans I have for the screensaver:
Changes
Issues