-
-
Notifications
You must be signed in to change notification settings - Fork 530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show currently playing music on screensaver #2512
Conversation
import org.koin.androidx.compose.get | ||
|
||
@Composable | ||
fun DreamContentNowPlaying( |
Check warning
Code scanning / detekt
One method should have one responsibility. Long methods tend to handle many things at once. Prefer smaller methods to make them easier to understand.
val imageBlurHash = imageTag?.let { tag -> item.imageBlurHashes?.get(ImageType.PRIMARY)?.get(tag) } | ||
|
||
val imageBlurHashBitmap = remember { | ||
if (imageBlurHash != null) BlurHash.decode(imageBlurHash, 32, 32)?.asImageBitmap() |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
val imageBlurHash = imageTag?.let { tag -> item.imageBlurHashes?.get(ImageType.PRIMARY)?.get(tag) } | ||
|
||
val imageBlurHashBitmap = remember { | ||
if (imageBlurHash != null) BlurHash.decode(imageBlurHash, 32, 32)?.asImageBitmap() |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
alignment = Alignment.Center, | ||
contentScale = ContentScale.Crop, | ||
modifier = Modifier.fillMaxSize(), | ||
colorFilter = ColorFilter.tint(Color(0f, 0f, 0f, 0.4f), BlendMode.SrcAtop) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
return@run albumArtist | ||
}.orEmpty(), | ||
style = TextStyle( | ||
color = Color(0.8f, 0.8f, 0.8f), |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
return@run albumArtist | ||
}.orEmpty(), | ||
style = TextStyle( | ||
color = Color(0.8f, 0.8f, 0.8f), |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
return@run albumArtist | ||
}.orEmpty(), | ||
style = TextStyle( | ||
color = Color(0.8f, 0.8f, 0.8f), |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
Changes
Screenshots

Issues