Add in-app screensaver #2539
Add in-app screensaver #2539
Conversation
nielsvanvelzen
added
enhancement
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| <item quantity="one">%1$s minute</item> | ||
| <item quantity="other">%1$s minutes</item> | ||
| </plurals> | ||
| <plurals name="hours"> |
Check warning
Code scanning / Android Lint
Unused resources
nielsvanvelzen
force-pushed
the
nowplaying-screensaver
branch
from
0d45f87 to
0fa64f4
Compare
| timer?.cancel() | ||
|
|
||
| // Hide when interacted with allowed cancelation or when disabled | ||
| if (_visible.value && (canCancel || !enabled || activityPaused)) { |
Check warning
Code scanning / detekt
Complex conditions should be simplified and extracted into well-named methods if necessary.
|
|
||
| AnimatedVisibility( | ||
| visible = visible, | ||
| enter = fadeIn(tween(1_000)), |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
| AnimatedVisibility( | ||
| visible = visible, | ||
| enter = fadeIn(tween(1_000)), | ||
| exit = fadeOut(tween(1_000)), |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
Changes
getQuantityStringutilityIssues