Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix all string capitalization #2563

Merged
merged 1 commit into from
Mar 5, 2023
Merged

Fix all string capitalization #2563

merged 1 commit into from
Mar 5, 2023

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Fix all string capitalization
    • Use sentence casing instead of word casing
  • Fix "QuickConnect -> "Quick Connect"

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Mar 4, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Mar 4, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 4, 2023
View reviewed changes
app/src/main/res/values/strings.xml
<string name="lbl_one_episode">1 Episode</string>
<string name="lbl_num_songs">%1$d Songs</string>
<string name="lbl_one_song">1 Song</string>
<string name="lbl_num_episodes">%1$d episodes</string>

Check warning

Code scanning / Android Lint

Potential Plurals

Formatting %d followed by words ("episodes"): This should probably be a plural rather than a string
app/src/main/res/values/strings.xml
<string name="lbl_one_song">1 Song</string>
<string name="lbl_num_episodes">%1$d episodes</string>
<string name="lbl_one_episode">1 episode</string>
<string name="lbl_num_songs">%1$d songs</string>

Check warning

Code scanning / Android Lint

Potential Plurals

Formatting %d followed by words ("songs"): This should probably be a plural rather than a string
app/src/main/res/values/strings.xml
<string name="lbl_shuffle_queue">Toggle shuffle</string>
<string name="lbl_next_item">Next item</string>
<string name="lbl_prev_item">Previous item</string>
<string name="lbl_up_next_colon">"Up next: "</string>

Check warning

Code scanning / Android Lint

Unused resources

The resource R.string.lbl_up_next_colon appears to be unused
@nielsvanvelzen nielsvanvelzen merged commit 1c0da72 into jellyfin:master Mar 5, 2023
@nielsvanvelzen nielsvanvelzen deleted the string-capitalization branch March 5, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero