Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove watched indicator from empty series #2589

Merged
merged 1 commit into from
Mar 13, 2023

Conversation

nielsvanvelzen
Copy link
Member

When an item is empty (e.g. series without any seasons or season without any episodes) the server returns the following userData:

{
	"UserData": {
		"UnplayedItemCount": 0,
		"PlaybackPositionTicks": 0,
		"PlayCount": 0,
		"IsFavorite": false,
		"Played": true,
		"Key": "57125afe-ff17-942b-760d-3ab3185e9aff"
	}
}

This is stupid because obviously the item cannot be "played" when there are no items. The app would always show a checkmark because Played==true, this is the same behavior as jellyfin-web but IMO the completely wrong behavior. Ideally this behavior would be changed on the server side but until that's a thing, here's a fix for the ATV app.

Changes

  • Don't show watched indicator when item (series/season/other) is empty

Issues

@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Mar 13, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Mar 13, 2023
@nielsvanvelzen nielsvanvelzen merged commit 7282a39 into jellyfin:master Mar 13, 2023
@nielsvanvelzen nielsvanvelzen deleted the empty-card-no-state branch March 13, 2023 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants