Migrate search to SDK to fix cancellation issues

[polson]

Changes
* Extends ItemItemRowAdapter and provides a suspending function for the search logic
* Suspending function is canceled when a new search happens
See comment below

The issue was caused by the old API client using Volley for HTTP requests, which launches a thread. It does not use a coroutine / suspending function, so even though the coroutine is being canceled with new search input, the api call is not.

Issues
#2726

[polson]

I think I would like to change this by doing a small refactor:

• Share a viewmodel between the two search fragments.
• Make the search call in the viewmodel.
• Pass the SearchHints to the ItemRowAdapter directly

Then we can move the search networking out of the ItemRowAdapter entirely. I noticed we're already doing this in a few places. There's an ItemRowAdapter constructor that takes in a list of ChapterItemInfo for example.

One annoying thing about this however is if we try to pass in a list of SearchHint it will conflict with that constructor because of type erasure. I dealt with this by passing in a Collection instead of a List

[nielsvanvelzen]

If we're migrating the search code to the SDK we should use the items API with the searchTerm parameter for the query instead. This API returns normal BaseItemDto models instead of search hints. The web client also uses this approach for searching.

[polson]

Updated this to use the new search api

[polson]

Addressed comments

[nielsvanvelzen]

Some files are indented with spaces instead of tabs, and a lot of places use (like constructors) use 2x the amount of indent compared to existing code.

[polson]

Sorry about the whitespace changes, I tend to use the AS formatter quite frequently so that's why it moved things around

[nielsvanvelzen]

Hmm that's weird, the default Android Studio config + our editorconfig should configure the formatter properly. I use it all the time. Maybe it broke in a newer version? I'll look into it.

[polson]

I tried out the Canary build of AS and I think that messed up the autoformatter. I'll fix it in the PR

[nielsvanvelzen]

I've made some additional changes;

• Updates formatting
• Moved searchJob?.cancel() to before the query.isBlank check to prevent a race condition where items wouldn't be cleared when emptying the input.

Thanks a lot for the pull request!