Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix screensaver support in video player #2749

Merged
merged 1 commit into from
May 10, 2023
Merged

Fix screensaver support in video player #2749

merged 1 commit into from
May 10, 2023

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Only allow screensaver to show when the player is paused
  • Always disable screensaver when using LibVLC (we don't use the events we'd need to hook into)

The implementation adds yet another "helper" file written in Kotlin. This time because the activityViewModel extension function from Koin can only be used in Kotlin code.

Issues

Fixes #2225

@nielsvanvelzen nielsvanvelzen added bug Something isn't working enhancement New feature or request labels May 10, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone May 10, 2023
@nielsvanvelzen nielsvanvelzen merged commit c95ee3a into jellyfin:master May 10, 2023
@nielsvanvelzen nielsvanvelzen deleted the player-screensaver branch May 10, 2023 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.

Screensaver not started when paused
2 participants
@nielsvanvelzen @thornbill