Replace ExoPlayer with androidx.media3 #2826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
nielsvanvelzen
force-pushed
the
media3-exoplayer
branch
from
c6c77da to
5121e29
Compare
nielsvanvelzen
force-pushed
the
media3-exoplayer
branch
from
5121e29 to
7cb4d2f
Compare
nielsvanvelzen
force-pushed
the
media3-exoplayer
branch
from
7cb4d2f to
0c7e05d
Compare
|
This is now ready. I'll likely add it to the 0.16 release branch later. |
crobibero
approved these changes
Dec 24, 2023
nielsvanvelzen
added
the
backportable
|
does backportable mean it'll land in v0.16.3? |
|
Not necessarily. The backportable label means it is a candidate for backporting. In this specific case I need to test the media3 migration more thoroughly first before sending it to half a million users. So it might be in 0.16.3 but could also be 0.16.4 or 0.17.0. |
|
ok thank you for clarifying 👍 |
nielsvanvelzen
added
enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace our usages of ExoPlayer with androidx.media3. This affects the old playback code and the rewritten code. It's pretty much only package name changes because I fixed the breaking changes in earlier PR's.
To do
Migrateexoplayer-ffmpeg-extensionto media3Issues
Also a part of #1057 I guess