Replace Glide with Coil #2889
Merged
Replace Glide with Coil #2889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
app/src/main/java/org/jellyfin/androidtv/integration/provider/ImageProvider.kt
Fixed
Show fixed
Hide fixed
| @@ -62,7 +64,7 @@ | |||
| ) | |||
| } | |||
|
|
|||
| private suspend fun getRandomLibraryShowcase(api: ApiClient, context: Context): DreamContent.LibraryShowcase? { | |||
| private suspend fun getRandomLibraryShowcase(api: ApiClient, imageLoader: ImageLoader, context: Context): DreamContent.LibraryShowcase? { | |||
Check warning
Code scanning / detekt
Line detected, which is longer than the defined maximum line length in the code style.
| Build.VERSION.SDK_INT >= Build.VERSION_CODES.R -> Bitmap.CompressFormat.WEBP_LOSSY | ||
| else -> Bitmap.CompressFormat.WEBP | ||
| } | ||
| drawable.toBitmap().compress(format, 95, outputStream) |
Check warning
Code scanning / detekt
Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.
crobibero
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a bunch of image loading libraries for Android and we've previously used Picasso and currently Glide only. It works well but the development is slow and there are some issues that are not being worked on.
Coil builds on top of modern Android standards like lifecycles and is Kotlin-first, just like our app. It fixes some issues and on top of that the performance is noticeably improved compared to our Glide implementation (try scrolling fast trough a library).
Changes
Issues
Fixes #2018