Fix crash when switching users while playing music #2923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only stopped playback after the user is changed, with this change we also stop media immediately after usiong the switch users button in the home toolbar
This fixes various crashes where API calls would fail after a session was destroyed. Most notable was the crash that occurred when stopping music playback when switching users
crobibero
approved these changes
Jul 29, 2023
thornbill
approved these changes
Jul 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we only stopped playback after the user is changed, with this change we also stop media immediately after usiong the switch users button in the home toolbar
Changes
Stop media playback when switching users
Previously we only stopped playback after the user is changed, with this change we also stop media immediately after usiong the switch users button in the home toolbar
Don't clear ApiClient credentials when destroying a session
This fixes various crashes where API calls would fail after a session was destroyed. Most notable was the crash that occurred when stopping music playback when switching users
Issues