Improve BaseRowItem refreshing (fix crash after item deletion) #2949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
crobibero
approved these changes
Aug 8, 2023
app/src/main/java/org/jellyfin/androidtv/ui/itemhandling/BaseRowItem.kt
Outdated
Show resolved
Hide resolved
- Fix race conditions where selected item would change during refresh - Catch API exceptions - Remove item from adapter when refresh fails - Format some files
nielsvanvelzen
force-pushed
the
item-refresh-delete
branch
from
82ba7b2 to
43858a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
should actually only happen with a 404 but the server returns a 500 🤷)Issues
Fixes #2948