Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Android 14 SDK (API 34) #2957

Merged
merged 3 commits into from
Sep 8, 2023

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Use Android 14 SDK (API 34)
    • Also removes the targets from library modules as those are deprecated
    • Fix one compile issue related to a signature change in the new SDK
  • Fix Koin deprecation warnings when using get<>() in Compose code

Issues

@nielsvanvelzen
Copy link
Member Author

Leaving this as draft for now as this SDK appears to be released but there hasn't been any announcement yet. At the same time the Compose update released today (1.5.0) indirectly depends on this SDK 🤷

@nielsvanvelzen
Copy link
Member Author

Because androidx.core now needs API 34 too I've updated the PR to compile with API 34 but target API 33 so we don't get the Android 14 behavior changes and everything should be fine. The fact that this SDK is not officially stable is still weird though.

@nielsvanvelzen nielsvanvelzen marked this pull request as ready for review September 8, 2023 18:40
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Sep 8, 2023
@nielsvanvelzen nielsvanvelzen added the enhancement New feature or request label Sep 8, 2023
@nielsvanvelzen nielsvanvelzen enabled auto-merge (rebase) September 8, 2023 18:44
@nielsvanvelzen nielsvanvelzen merged commit c793771 into jellyfin:master Sep 8, 2023
@nielsvanvelzen nielsvanvelzen deleted the android-sdk-34 branch September 8, 2023 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants