Fix disabling subtitles not always working #2984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nielsvanvelzen
added
backportable
thornbill
approved these changes
Aug 19, 2023
nielsvanvelzen
deleted the
please-turn-the-subtitles-off-when-i-ask-for-it
branch
nielsvanvelzen
added
the
backportable
nielsvanvelzen
removed
the
backportable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested the specific case where the subtitles are on by default and require transcoding. Disabling those will set the index to
-1which was ignored in the PlaybackManagergetVideoStreamInfofunction so the server would happily reply the video info with default subtitles enabled.Changes
Issues
Fixes #2045
Fixes #2631