Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SuggestedMoviesFragment to SDK #3049

Merged
merged 2 commits into from
Sep 15, 2023
Merged

Migrate SuggestedMoviesFragment to SDK #3049

merged 2 commits into from
Sep 15, 2023

Conversation

nielsvanvelzen
Copy link
Member

@nielsvanvelzen nielsvanvelzen commented Sep 14, 2023 •
edited
Loading

Changes

  • Migrate SuggestedMoviesFragment to Kotlin
  • Migrate SuggestedMoviesFragment to SDK
    • Except for the ItemRowAdapter thingy
  • Use string template for the "because you watched x" string

Issues

@nielsvanvelzen nielsvanvelzen added sdk-migration To fix this we need to migrate some code to the new SDK refactor Improvements to code realiability, readability and quality labels Sep 14, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.0 milestone Sep 14, 2023
@nielsvanvelzen
Copy link
Member Author

I think this is the last SDK migration for a bit (again). Left over code is either playback related or the item row adapter which will be a pain to do.

github-advanced-security[bot]
github-advanced-security bot found potential problems Sep 14, 2023
View reviewed changes
app/src/main/java/org/jellyfin/androidtv/ui/browsing/SuggestedMoviesFragment.kt
)

for (item in response.items.orEmpty()) {
// TODO: Migrate ItemRowAdapter to SDK

Check warning

Code scanning / detekt

Flags a forbidden comment.

Forbidden TODO todo marker in comment, please do the changes.
app/src/main/java/org/jellyfin/androidtv/ui/browsing/SuggestedMoviesFragment.kt
ItemFields.MediaStreams,
ItemFields.MediaSources
)
similar.limit = 7

Check warning

Code scanning / detekt

Report magic numbers. Magic number is a numeric literal that is not defined as a constant and hence it's unclear what the purpose of this number is. It's better to declare such numbers as constants and give them a proper name. By default, -1, 0, 1, and 2 are not considered to be magic numbers.

This expression contains a magic number. Consider defining it to a well named constant.
@nielsvanvelzen nielsvanvelzen merged commit 8c71756 into jellyfin:master Sep 15, 2023
@nielsvanvelzen nielsvanvelzen deleted the sdk-suggest-movies branch September 15, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
refactor Improvements to code realiability, readability and quality sdk-migration To fix this we need to migrate some code to the new SDK
Projects
None yet
Milestone
v0.16.0
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero