Fix crash when starting player where playback controller may be null #3232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| playerAdapter = new VideoPlayerAdapter(playbackController, this); | ||
| playerGlue = new CustomPlaybackTransportControlGlue(getContext(), playerAdapter, playbackController); | ||
| playerGlue.setHost(new CustomPlaybackFragmentGlueHost(this)); | ||
| } | ||
|
|
||
| public void initFromView(PlaybackController playbackController, CustomPlaybackOverlayFragment customPlaybackOverlayFragment) { | ||
| this.playbackController = playbackController; | ||
| public void initFromView(CustomPlaybackOverlayFragment customPlaybackOverlayFragment) { |
Check notice
Code scanning / Android Lint
Unknown nullness
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This code is messy but basically we do a lot of magic to send the "PlaybackController" instance from the CustomPlaybackOverlayFragment to LeanbackOverlayFragment. This happened in two ways: via the PlaybackControllerContainer and the initFromView function. Then both classes contained a (m)playbackController variable to store the value.
In this PR I did a few things:
While I cannot reproduce the issue and thus have no idea if this fixes it, this PR does give the 🍝 a bit more 🌶️.
Issues
Hopefully fixes #3231