Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix opening collections via search results showing empty screen #3246

Merged
merged 1 commit into from
Dec 24, 2023
Merged

Fix opening collections via search results showing empty screen #3246

merged 1 commit into from
Dec 24, 2023

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Fix opening collections via search results showing empty screen
    • The childCount property is not set for search results so when the collection screen opened it would never load data. Removed a (unnecessary?) check.
    • Reformat file / remove useless onActivityCreated function that just calls super
    • Use BaseItemKind enum instead of strings for queries

Issues

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Dec 23, 2023
@nielsvanvelzen nielsvanvelzen added this to the v0.16.3 milestone Dec 23, 2023
@nielsvanvelzen nielsvanvelzen merged commit 2bbbb93 into jellyfin:master Dec 24, 2023
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the search-collection branch December 24, 2023 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thornbill thornbill thornbill approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.16.3
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @thornbill