Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix downmixing AAC to stereo audio in exoplayer #3360

Merged
merged 1 commit into from
Feb 11, 2024

Conversation

MichaelRUSF
Copy link
Contributor

@MichaelRUSF MichaelRUSF commented Feb 10, 2024

Changes
Add a condition to set max audio channels to 2 when downmixing support is enabled.

Issues
Fixes #3227

@nielsvanvelzen nielsvanvelzen added the bug Something isn't working label Feb 11, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Feb 11, 2024
@nielsvanvelzen nielsvanvelzen merged commit d5c5bcc into jellyfin:master Feb 11, 2024
5 checks passed
@nielsvanvelzen
Copy link
Member

Thanks!

@nielsvanvelzen nielsvanvelzen added backportable Change may be backported to a point release (remove label once cherrypicked) and removed backportable Change may be backported to a point release (remove label once cherrypicked) labels Feb 11, 2024
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.17.0, v0.16.5 Feb 11, 2024
@MaximeLussier
Copy link

@MichaelRUSF Is this also present in the Android (not AndroidTV) code?

@MichaelRUSF
Copy link
Contributor Author

The Android issue seems to be related to the server or webUI. I just opened an issue on the server repo regarding my findings.

@MichaelRUSF MichaelRUSF deleted the Downmixing_audio_fix branch February 13, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Downmix to Stereo Option is Ignored in Exoplayer for AAC Audio
3 participants