Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash when updating clock in FullDetailsFragment while item information is unavailable #3371

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Fix crash when updating clock in FullDetailsFragment while item information is unavailable #3371

merged 1 commit into from
Feb 14, 2024

Conversation

nielsvanvelzen
Copy link
Member

Changes

  • Check if view holder is set (it won't be when the base item is not set) before trying to update the "ends at" of an item
  • Add onError implementation for item refresh that logs the issue and navigates back

Issues

@nielsvanvelzen nielsvanvelzen added bug Something isn't working backportable Change may be backported to a point release (remove label once cherrypicked) labels Feb 14, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Feb 14, 2024
@nielsvanvelzen nielsvanvelzen merged commit 68b5780 into jellyfin:master Feb 14, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the fdf-clock-crash branch February 14, 2024 21:07
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.17.0, v0.16.6 Feb 25, 2024
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crobibero crobibero crobibero approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
v0.16.6
Development

Successfully merging this pull request may close these issues.
2 participants
@nielsvanvelzen @crobibero