Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash when checking whether a person is a folder or not #3399

Merged

Conversation

nielsvanvelzen
Copy link
Member

Spoiler: they are not (mostly).

Changes

  • Fix a crash in ItemLauncher when isFolder() returns null
  • Add item fields to all queries in CollectionFragment, didn't fix the crash but they are probably needed somewhere in this spaghetti.

Issues

Fixes #3397

@nielsvanvelzen nielsvanvelzen added bug Something isn't working backportable Change may be backported to a point release (remove label once cherrypicked) crash Bug causing app crashes labels Feb 22, 2024
@nielsvanvelzen nielsvanvelzen added this to the v0.17.0 milestone Feb 22, 2024
@nielsvanvelzen nielsvanvelzen merged commit efc6be8 into jellyfin:master Feb 22, 2024
5 checks passed
@nielsvanvelzen nielsvanvelzen deleted the persons-are-not-folders branch February 22, 2024 19:19
@nielsvanvelzen nielsvanvelzen modified the milestones: v0.17.0, v0.16.6 Feb 25, 2024
@nielsvanvelzen nielsvanvelzen removed the backportable Change may be backported to a point release (remove label once cherrypicked) label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crash Bug causing app crashes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

App crashes when opening a person within a boxset
2 participants