Fix segmentation fault on strftime/1
and strflocaltime/1
#3271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we use a large format string to
strftime/1
andstrflocaltime/1
,we get segmentation fault. This happens because the result buffer is
allocated on the stack using
alloca
function, andstrftime
functionwrites out of the space when the size is not enough to format time.
I fixed the segmentation fault issue by allocating the result buffer on
the heap using
malloc
function, becausealloca
function does notprovide a way to detect insufficient space.