Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH] Enable LTO and Set codegen-units to 1 for Release Builds #370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

samadpls
Copy link

Fixes #360

@zamazan4ik
Copy link

Thank you for the PR! One question: why didn't you enable this change just in this file? Because with your variant you have the following warning in the build logs:

#17 0.173 warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
#17 0.173 package:   /arch/llm_gateway/Cargo.toml
#17 0.173 workspace: /arch/Cargo.toml
#17 0.173 warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
#17 0.173 package:   /arch/prompt_gateway/Cargo.toml
#17 0.173 workspace: /arch/Cargo.toml
#17 0.257    Compiling llm_gateway v0.1.0 (/arch/llm_gateway)
#17 2.886     Finished `release` profile [optimized] target(s) in 2.71s
#17 DONE 2.9s

@samadpls samadpls force-pushed the enable-lto-and-codegen-units branch 5 times, most recently from 05e0552 to 6b5ba96 Compare January 23, 2025 14:12
@samadpls
Copy link
Author

Hi @adilhafeez , could you please re-run the workflow for this PR at your convenience? This helps me update the PR accordingly.

@samadpls samadpls force-pushed the enable-lto-and-codegen-units branch from 6b5ba96 to 0c1c1e5 Compare January 25, 2025 10:55
@samadpls samadpls force-pushed the enable-lto-and-codegen-units branch from 0c1c1e5 to f6a8abb Compare January 30, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Link-Time Optimization (LTO) and codegen-units = 1
2 participants