Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release-0.18] Pin knative deps to release-0.18 #1025

Merged
merged 5 commits into from
Sep 23, 2020
Merged

[Release-0.18] Pin knative deps to release-0.18 #1025

merged 5 commits into from
Sep 23, 2020

Conversation

ZhiminXiang
Copy link

@ZhiminXiang ZhiminXiang commented Sep 22, 2020 •
edited
Loading

  • Pin knative deps to release-0.18
  • Use k8s 1.18.8 version

@googlebot googlebot added the cla: yes Indicates the PR's author has signed the CLA. label Sep 22, 2020
@knative-prow-robot knative-prow-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Sep 22, 2020
@ZhiminXiang
Copy link
Author

/assign @n3wscott

maximilien
maximilien reviewed Sep 23, 2020
View reviewed changes
Copy link
Contributor

@maximilien maximilien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@knative-prow-robot knative-prow-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Sep 23, 2020
@ZhiminXiang
Copy link
Author

I think when pinning pkg to release-0.18, it requires bumping k8s version to 1.18.8.

@ZhiminXiang ZhiminXiang changed the title [Release-0.18] Pin pkg to release-0.18 [Release-0.18] Pin knative deps to release-0.18 Sep 23, 2020
@ZhiminXiang
Copy link
Author

/retest

navidshaikh
navidshaikh approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR also takes care of bumping k8s dep as done separately in #1011 , so we can get this in and close the other. cc: @rhuss

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 23, 2020
@ZhiminXiang
Copy link
Author

Can I get an lgtm for this PR?

@n3wscott
Copy link
Contributor

/lgtm
/approve

@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 23, 2020
navidshaikh
navidshaikh approved these changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@navidshaikh navidshaikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: n3wscott, navidshaikh, ZhiminXiang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot merged commit 9b210e3 into knative:master Sep 23, 2020
@navidshaikh navidshaikh mentioned this pull request Sep 25, 2020
Closed
@MIBc MIBc mentioned this pull request Sep 26, 2020
Closed
rhuss pushed a commit to rhuss/knative-client that referenced this pull request Oct 5, 2020
@rhuss
[Release-0.18] Pin knative deps to release-0.18 (knative#1025)
17e57ce 
* Pin pkg to release-0.18 version

* ./hack/update-deps.sh --upgrade && ./hack/update-codegen.sh

* bump k8s version to 1.18.8

* Fix the brokerage of importing latest serving

* exclude script/test-infra md from md check
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maximilien maximilien maximilien left review comments

@navidshaikh navidshaikh navidshaikh approved these changes

Assignees

@navidshaikh navidshaikh

@n3wscott n3wscott

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the CLA. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ZhiminXiang @n3wscott @knative-prow-robot @maximilien @navidshaikh @googlebot