fix: Fix default config path on Windows #752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knative-prow-robot
added
the
size/S
|
The following is the coverage report on the affected files.
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk, navidshaikh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow-robot
added
the
approved
dsimansk
added a commit
to dsimansk/client
that referenced
this pull request
Mar 23, 2020
knative-prow-robot
pushed a commit
that referenced
this pull request
Mar 24, 2020
* fix(trigger): Make --filter flag truly optional (#745) * fix(trigger): Make --filter flag truly optional * fix(trigger): Update trigger docs * chore: Update changelog * fix(trigger): Fix filter delete for trigger update (#746) * chore: Update changelog * Fix plugin execution for Windows (#738) Fixes #737 * Use exec.Command instend of syscall.Exec for windows. * Fix a bug in plugin handler test when running it on windows. * Fix typo. * fix: Fix default config path on Windows (#752) Co-authored-by: Lv Jiawei <[email protected]>
navidshaikh
added
the
backport/pr
rhuss
added
backported-to/0.13
and removed
backport/pr
coryrc
pushed a commit
to coryrc/client
that referenced
this pull request
May 14, 2020
* added basic kubernetes app skeleton for infra monitoring * only copy the tools directory for building the monitoring tool
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add function that returns default path based on OS.
Changes
newDefaultConfigPathto return OS-based paths