Fix Panic for kn source ping describe with Sink URI

[danielhelfand]

Description

This pull request moves all Sink.Ref properties from being referenced for kn source ping describe until after it has been checked if Sink.Ref is nil due to using a URI instead of a Ref.

It also fixes tests for kn source ping describe, which are not asserting whether command output is successfully returned or not.

Reference

Fixes #847

/lint

[knative-prow-robot]

@danielhelfand: 0 warnings.

In response to this:

Description

This pull request moves all Sink.Ref properties from being referenced for kn source ping describe until after it has been checked if Sink.Ref is nil due to using a URI instead of a Ref.

It also fixes tests for kn source ping describe, which are not asserting whether command output is successfully returned or not.

Reference

Fixes #847

/lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow-robot]

Hi @danielhelfand. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jchesterpivotal]

/ok-to-test

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/kn/commands/source/ping/describe.go	83.7%	86.0%	2.3

[jchesterpivotal]

LGTM.

[rhuss]

Thanks for the PR ! Highly appreciated ...

/lgtm
/approve

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielhelfand, rhuss

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rhuss]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment