Add mock tests for the dynamic client

[priyshar01]

Description

Adding mock test client for the dynamic client.

Changes

Added mock tests for Dynamic client.

Fixes #952

[knative-prow-robot]

Hi @priyshar01. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[priyshar01]

/assign @navidshaikh

[navidshaikh]

/ok-to-test

[knative-metrics-robot]

The following is the coverage report on the affected files.
Say /test pull-knative-client-go-coverage to re-run this coverage report

File	Old Coverage	New Coverage	Delta
pkg/dynamic/client_mock.go	Do not exist	90.9%

[maximilien]

Looks OK. And certainly needed and thanks for contribution. However, I wonder how much more useful it would be to think about introducing automated mock generation rather than custom crafted ones. See for instance Counterfeiter or other similar tools.

Anyhow, not asking to change now, but if we need to create more mocks, IMO, an automated tool helps and is faster. Additionally with above, any change to the DynamicClient requires custom changes to the mock and test and nothing will fail to indicate that this needs to be done.

My .02

[navidshaikh]

/lgtm
/approve

thanks for the contribution!

[knative-prow-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: maximilien, navidshaikh, priyshar01

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [maximilien,navidshaikh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment