adds streamable feature to the library #166
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there. I've been working on this feature to make it possible to stream SSR react projects made with isomorphic-style-loader. Even though this is not backward compatible I sent you the initial modifications so that we can discuss on what I'm doing here. With this implementation the only change that you need to make to the code is this:
Users of this library must pass the CSS set and a flag that shows if this code is running on server or not (which can be detected by default if not provided but passing CSS set is mandatory). Before I go ahead and add tests for this feature let me know your thoughts. If you merge this we can have corresponding improvements on react-starter-kit as well.